+1

IPMC and PPMC binding.

One fix needed:

website links are wrong - this is not a blocker for me (a manual alternation of the website content is acceptable - it's only a link template typo).

- - - - - - - - - - -

Simone - Excellent work.

1/ Problems in any23-service-embedded but possibly user error due to time of day. [*]
2/ Couple of comments on the plugins that I noticed.  Not blockers.

        Andy

[*] and whether everything works or not is not technically a blocker!
Release early, release often.

----------------------

Details:

> Staging site:
> http://incubator.apache.org/any23/0.7.0-incubating

Awesome - mirrors links

****   s/incuabtor/incubator/g !!

and then a few mirrors I tried do have the directory.

== apache-any23-0.7.0-incubating-src

Good.
N&L look good, "mvn clean test" passes

(thx for the name change)

== apache-any23-core-0.7.0-incubating/

N&L look good
bin/any23 does something.

repeated in LICENSE
[[
For the TagSoup component (http://home.ccil.org/~cowan/XML/tagsoup/)
This is licensed under the The Apache Software License, Version 2.0, see above
]]

[[README.txt
 export JAVA_HOME=/usr/java/jdk1.5.0_02
]]
is Java 1.5 supported?  How quaint :-)

== apache-any23-service-0.7.0-incubating-server-embedded

N&L look good

 bin/any23server --port 8010

Whatever port I try I get:

2012-07-04 22:12:02.262:WARN:oejuc.AbstractLifeCycle:FAILED [email protected]:8080 FAILED: java.net.BindException: Address already in use

(says 8080)

There are 3 "java.net.BindException: Address already in use"

== apache-any23-service-0.7.0-incubating-with-deps/

N&L good.
N&L in WAR file look good.

== apache-any23-service-0.7.0-incubating-without-deps/

N&L good.
Nice they are specialised for this form.

== apache-any23-basic-crawler-1.0.0-incubating/

N&L: Good, especially BDB-JE.

== apache-any23-html-scraper-1.0.1-incubating

N&L acceptable.

The POI jar includes a NOTICE but looking at the jar class files, it's all under org.apache.poi so if there is any such code in the jar, it's been granted because it's been changed.

But then it's LICENSE has JUnit stuff which is not in the jar also suggesting a packaging error.

== apache-any23-html-scraper-1.0.1-incubating

N&L acceptable.

boilerpipe includes (binary) cyberneko
Ideally, IMHO, include in NOTICE but not a blocker (it's ASL license, binary redistribution, but it itself does provide a NOTICE file so ASL requirement to propagate NOTICE does not come into force).



Reply via email to