Hi, I have a patch on GitHub [1] available to move the test resources out into their own module and modify the tests to work by copying the resources out to temporary files that are all cleaned up by JUnit after each test.
The Apache Jira does not appear to be available right now, but this corresponds to ANY23-103 that I filed in June. Could someone review that patch for me as it is quite large and I may have added something that was not necessary. This patch is the precursor to the modularisation process, as without it the tests cannot be moved out of the core module. Thanks, Peter [1] https://github.com/ansell/any23/compare/trunk...test-resource-jar On 7 August 2012 21:16, Lewis John Mcgibbney <[email protected]> wrote: > Hi Simo, > > I also provide my full backing for this. I think Peter's suggestion > here was an excellent injection and I would back the restructuring > effort entirely as well. > Lewis > > On Tue, Aug 7, 2012 at 10:18 AM, Simone Tripodi > <[email protected]> wrote: >> Hi Peter, >> >>> I am looking in the short term to restructure the Maven modules inside >>> of Any23 so that the different facets can be reused, tested and >>> maintained easily, particularly with a view to using the RDF related >>> Tika enhancements that the Any23 MIME Detector provides. I made these >>> changes a few months ago in my GitHub fork [2], so feel free to review >>> them closely to suggest enhancements before I actually start. I am not >>> sure when I will next have time to clean up the patches. The first >>> step that I want to take is to split out the test resources into a >>> single module and switch from "src/test/resources/*" File based access >>> in tests to using this.getClass().getResourceAsStream("*"). I have >>> implemented those changes in my git repository but the patches may >>> need cleaning up as I have not gone back to review them yet. After >>> that is done, it will be relatively simple to split out both the >>> packages and tests into separate modules. >> >> You have my full support on this step, I would be more than glad to >> provide feedbacks - feel free to ping me when/if needed! >> >> I also think we could take advantage from this work to get rid of many >> builders-of-factories and switching the Any23 runtime environment to >> something more standard-ish, i.e. JSR-330 >> <http://www.jcp.org/en/jsr/detail?id=330> >> >> Have a nice day, all the best! >> -Simo >> >> http://people.apache.org/~simonetripodi/ >> http://simonetripodi.livejournal.com/ >> http://twitter.com/simonetripodi >> http://www.99soft.org/ > > > > -- > Lewis
