Hi Simone, The styling for the added classes was the style I use for my typical coding.
I switched the Any23 project in my Eclipse to use the java opening-brace-on-same-line convention. I have been brought up on something that I now know looks more like a typical C# convention, opening brace for a block below the element, not beside, although I was taught it in Java. I also switched my Eclipse XML formatter to use 2 spaces (instead of a mix of 1 tab or 4 spaces that it was previously set to) and reformatted the pom.xml files that were not compliant. I can't seem to find a way in Eclipse to setup the XML formatter by project, so I will have to remember to switch back to 2 spaces when committing to Any23, but the java convention should be consistent. Cheers, Peter On 10 August 2012 16:55, Simone Tripodi <[email protected]> wrote: > Good, I can review all the changes during the weekend! > > In the meanwhile, can you please fix the code format in both Java & > XML according to the adopted? The snippet below doesn't seem it is > compliant, looks like you are using tabs or 4 spaces (in XML we uses 2 > spaces). > I didn't check the rest - you committed a lot of stuff :) - I will do > during the WE. > > Thanks!! > -Simo > >> </plugin> >> + <plugin> >> + <groupId>org.apache.maven.plugins</groupId> >> + <artifactId>maven-jar-plugin</artifactId> >> + <executions> >> + <execution> >> + <goals> >> + <goal>test-jar</goal> >> + </goals> >> + </execution> >> + </executions> >> + </plugin> >> </plugins> > > http://people.apache.org/~simonetripodi/ > http://simonetripodi.livejournal.com/ > http://twitter.com/simonetripodi > http://www.99soft.org/
