On Mon, Sep 29, 2008 at 11:41:13AM -0500, Jon Nelson wrote:
> Mounting an AoE device (as exported by vblade 18 using aoe kernel
> module 64, kernel 2.6.25.16, x86-64) I get:
>
> Sep 29 11:36:15 turnip kernel: SKB BUG: Invalid truesize (352)
> len=548, sizeof(sk_buff)=224
> Sep 29 11:36:15 turnip kernel: SKB BUG: Invalid truesize (352)
> len=548, sizeof(sk_buff)=224
> Sep 29 11:36:19 turnip kernel: SKB BUG: Invalid truesize (352)
> len=548, sizeof(sk_buff)=224
>
> Ideas?
Yes, a couple people have noticed this using loopback networking.
What kind of networking were you using?
The attached patch is reported to help. Please let me know how it
works for you.
--
Ed Cashin <[EMAIL PROTECTED]>
diff --git a/linux/drivers/block/aoe/aoe.h b/linux/drivers/block/aoe/aoe.h
index 953cb0a..e646537 100644
--- a/linux/drivers/block/aoe/aoe.h
+++ b/linux/drivers/block/aoe/aoe.h
@@ -1,5 +1,5 @@
/* Copyright (c) 2007 Coraid, Inc. See COPYING for GPL terms. */
-#define VERSION "64"
+#define VERSION "64truesz"
#define AOE_MAJOR 152
#define DEVICE_NAME "aoe"
diff --git a/linux/drivers/block/aoe/aoecmd.c b/linux/drivers/block/aoe/aoecmd.c
index 84987f4..63b6f9d 100644
--- a/linux/drivers/block/aoe/aoecmd.c
+++ b/linux/drivers/block/aoe/aoecmd.c
@@ -216,6 +216,7 @@ bail: aoe_freetframe(f);
f->skb = skb;
}
+ skb->truesize -= skb->data_len;
skb_shinfo(skb)->nr_frags = skb->data_len = 0;
skb_trim(skb, 0);
return f;
@@ -361,6 +362,7 @@ aoecmd_ata_rw(struct aoedev *d)
ah->aflags |= AOEAFL_WRITE;
skb->len += bcnt;
skb->data_len = bcnt;
+ skb->truesize += bcnt;
t->wpkts++;
} else {
t->rpkts++;
diff --git a/linux/drivers/block/aoe/aoedev.c b/linux/drivers/block/aoe/aoedev.c
index b2c2077..791d32b 100644
--- a/linux/drivers/block/aoe/aoedev.c
+++ b/linux/drivers/block/aoe/aoedev.c
@@ -349,6 +349,7 @@ skbfree(struct sk_buff *skb)
skb->dev ? skb->dev->name : "netif");
return;
}
+ skb->truesize -= skb->data_len;
skb_shinfo(skb)->nr_frags = skb->data_len = 0;
skb_trim(skb, 0);
dev_kfree_skb(skb);
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Aoetools-discuss mailing list
Aoetools-discuss@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/aoetools-discuss
