On Tue, 2009-05-12 at 20:36 +0400, Alexey Pechnikov wrote: > Hello! > > I'm sorry but the problem is produced by patch for non-english locale. > This patch use wrong format string: > snprintf(buf, 40, "%s, %d %s %d %02d:%02d:%02d GMT", > > I did fix the bug and I'm think this patch may be added to upstream.
At first I thought that you were fixing a bad patch. But the diff isn't a fix of the bug, it is a good replacement for stupidly-generic code (which we still are using in AOLserver). We are still left with the question of how the original problem was created. From my research it appears that the locale would never affect the numbers (it couldn't be wrong with the day format and right with the time format), so we could change the locale with no effect on the output. We have evidence that the locale had no effect. My best guess is that someone created an almost perfect patch to the code you were using. It fixed the day-name and month-name problems, but it screwed up the day-number format. But your patch does not record the bug, just the original code, which would not produce the output we have been using. What gives? You include the buggy snprintf line above, but this isn't in the patch. tom jackson -- AOLserver - http://www.aolserver.com/ To Remove yourself from this list, simply send an email to <[email protected]> with the body of "SIGNOFF AOLSERVER" in the email message. You can leave the Subject: field of your email blank.
