Bugs item #437324, was opened at 2001-06-29 03:42 You can respond by visiting: http://sourceforge.net/tracker/?func=detail&atid=103152&aid=437324&group_id=3152
Category: API: Tcl Group: aolserver4_0 >Status: Closed >Resolution: Fixed Priority: 5 Submitted By: Yon Derek (yond) >Assigned to: Jim Davidson (jgdavidson) Summary: Incorrect CheckId() usage Initial Comment: All code that does !CheckId() should be changed to (TCL_OK != CheckId()), mostly tclresp.c It's AOLServer 4 as in CVS. ---------------------------------------------------------------------- >Comment By: Jim Davidson (jgdavidson) Date: 2001-11-25 12:25 Message: Logged In: YES user_id=20624 Changed CheckId TCL_OK/TCL_ERROR return to 1/0. ---------------------------------------------------------------------- Comment By: Yon Derek (yond) Date: 2001-07-08 15:07 Message: Logged In: YES user_id=237811 corrected the patch ---------------------------------------------------------------------- Comment By: Yon Derek (yond) Date: 2001-07-08 15:03 Message: Logged In: YES user_id=237811 Patch attached. Repro steps: start the server and get inexistent web page. You'll see a message in server log about invalid command. You shouldn't see that log, command has succeeded. Reason is that all procs that use CheckID() will return TCL_ERROR instead of TCL_OK. They should only return TCL_ERROR when connection id is invalid. ---------------------------------------------------------------------- You can respond by visiting: http://sourceforge.net/tracker/?func=detail&atid=103152&aid=437324&group_id=3152
