On 2005.02.23, Tom Jackson <[EMAIL PROTECTED]> wrote:
> I have submitted a feature enhancement request for this available at:
>
> <https://sourceforge.net/tracker/?func=detail&atid=353152&aid=1124272&group_id=3152>
>
> If anyone has a problem with me committing these changes to the
> current CVS, please speak up. I'll wait a week then commit my changes,
> unless requested not to.
I don't have a problem with these changes being committed since you say:
> The patch will not change any existing functionality.
However, I have one small nit to pick: many "changes" in the patch are
simply formatting-related (converting hard tabs to spaces) which I agree
should be done, but could you separate that into its own patch? It's
hard to see what your actual proposed changes are amongst all the noise
of changes which are strictly reformatting of existing code.
Since you say your change doesn't change any existing functionality,
then the next logical step is that code should be updated to use the new
Ns_ConfigSetValue API to record all config settings, correct? We want
to ensure that Ns_ConfigSetValue when called after the config interp is
done evaluating the config.tcl and initializing all the modules, but
before the server actually "starts up" that we set a boolean to indicate
"from this point forward, no more changes to the config" so that
Ns_ConfigSetValue will return an error.
Because of this, I'm not too happy with Ns_ConfigSetValue returning a
(char *) but would rather it return (int) for NS_OK/NS_ERROR.
> One deficiency of the new API is the inability to document the use of NULL
> values as a default. One instance is the nslog format string.
Huh? Why not:
Ns_ConfigSetValue("ns/parameters", "key", NULL);
Then, you can either test for NULL in Tcl with [ns_set isnull setId key]
or in C with "value == NULL" tests.
Or, do you mean something else and I'm misunderstanding you?
-- Dossy
--
Dossy Shiobara mail: [EMAIL PROTECTED]
Panoptic Computer Network web: http://www.panoptic.com/
"He realized the fastest way to change is to laugh at your own
folly -- then you can let go and quickly move on." (p. 70)
--
AOLserver - http://www.aolserver.com/
To Remove yourself from this list, simply send an email to <[EMAIL PROTECTED]>
with the
body of "SIGNOFF AOLSERVER" in the email message. You can leave the Subject:
field of your email blank.
