Re: [AOLSERVER] Ns_ConnReadLine return codes

[Jim Davidson]

In a message dated 6/11/05 2:17:01 PM, [EMAIL PROTECTED] writes:

I can not find any 'return NS_OK' in nsd/connio.c::Ns_ConnReadLine.
There are just two occurences of 'return NS_ERROR'. Is it so
intentionally?

Stupid bug -- I fixed it and checked it into the head version.

Together with it, I can not find other places with 'maxline'
configuration usage. The Ns_ConnReadLine function is used in
Ns_ConnReadHeaders, but I can not find any call for that function.

True -- the reason is it's not called anywhere which is a result of the new I/O model in 4.0.  Briefly, prior to 4.0, the server would accept connections and dispatch them immediately to threads which would do the actual, potentially blocking, reads from the client/browser.  In 4.0, all reads are performed after accepting the connection and before dispatch to the threads for processing by the event-driven I/O thread(s).  The goal is to do the potentially blocking reads via cheap I/O event callbacks instead of in the comparably far more expensive (from a resource perspective) context of an execution thread.

The old API's, Ns_ConnReadHeaders and Ns_ConnReadLine, where made backward compatible, simply maintaining a offset/length into the pre-read content.  In practice, I wasn't aware of anyone ever using those API's so I'm not surprised my stupid bug went un-noticed for so long.

-JIm
2">