Thanks. For some reason I remember the original patch having only a char
* declaration. I'll get it into the source.

Jozsef Hollosi wrote:
> 
> Dear Chuck:
> 
> You properly caught the small, but real memory leak in the patch I sent in,
> however, the just-released 1.2b11 has the leaked version of the path.
> Although it is a minor issue, because the whole leak is at most
> (2 * sizeof(char*))*MaxRequestsPerChild, which is just a few hundred bytes
> in most typical configurations, but you might still want to fix it for
> aesthetics.
> 
> Here is a suggested fix to the fix:
> 
> % diff proxy_util.c proxy_util.c.orig
> 704d703
> <     static char* charpbuf[2];
> 724c723
> <           hpbuf.h_addr_list = charpbuf;
> ---
> >           hpbuf.h_addr_list = malloc(2 * sizeof(char*));
> 
> Best Regards,
> Jozsef
> 
> >  *) Added code to return the requested IP address from proxy_host2addr()
> >     if gethostbyaddr() fails due to reverse DNS lookup problems. Original
> >     change submitted by Jozsef Hollosi <[EMAIL PROTECTED]>.
> >     [Chuck Murcko] PR#614
> 
> and
> 
> > Synopsis: proxy does not handle numeric addresses in URL
> >
> > State-Changed-From-To: analyzed-closed
> > State-Changed-By: chuck
> > State-Changed-When: Tue May 27 01:05:59 PDT 1997
> > State-Changed-Why:
> > Added user patch with small change to insure no leaks.

-- 
chuck
Chuck Murcko
The Topsail Group, West Chester PA USA
[EMAIL PROTECTED]

Reply via email to