>Number:         797
>Category:       mod_include
>Synopsis:       Erroneous error messages in mod_include.c
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    apache (Apache HTTP Project)
>State:          open
>Class:          change-request
>Submitter-Id:   apache
>Arrival-Date:   Sat Jun 28 10:10:01 1997
>Originator:     [EMAIL PROTECTED]
>Organization:
apache
>Release:        1.2.0
>Environment:
BSD/OS killer-whale.automatrix.com 2.0 BSDI BSD/OS 2.0 Kernel #4: Thu May  2 
08:14:06 EDT 1996     [EMAIL PROTECTED]:/usr/src/sys/compile/KILLER-WHALE  i386
gcc version 2.7.2.2
>Description:
hande_exec displays incorrect error messages.
>How-To-Repeat:

>Fix:
Here's a patch.  It fixes the error message in handle_exec and wraps `' around
the command names in the other messages in mod_include.c

diff -c2 mod_include.c~ mod_include.c
*** mod_include.c~      Wed Jun  4 20:57:45 1997
--- mod_include.c       Sat Jun 28 12:53:36 1997
***************
*** 579,583 ****
              return 0;
          else {
!             log_printf(r->server, "unknown parameter %s to tag include in %s",
                         tag, r->filename);
              rputs(error, r);
--- 579,583 ----
              return 0;
          else {
!             log_printf(r->server, "unknown parameter `%s' to tag include in 
%s",
                         tag, r->filename);
              rputs(error, r);
***************
*** 684,688 ****
              parse_string(r, tag_val, parsed_string, MAX_STRING_LEN, 1);
              if(include_cmd(parsed_string, r) == -1) {
!                 log_printf(r->server, "unknown parameter %s to tag include in 
%s",
                             tag, r->filename);
                  rputs(error, r);
--- 684,688 ----
              parse_string(r, tag_val, parsed_string, MAX_STRING_LEN, 1);
              if(include_cmd(parsed_string, r) == -1) {
!                 log_printf(r->server, "execution failure for parameter `%s' 
to tag exec in %s",
                             tag, r->filename);
                  rputs(error, r);
***************
*** 703,707 ****
              return 0;
          else {
!             log_printf(r->server, "unknown parameter %s to tag exec in %s",
                         tag, file);
              rputs(error, r);
--- 703,707 ----
              return 0;
          else {
!             log_printf(r->server, "unknown parameter `%s' to tag exec in %s",
                         tag, file);
              rputs(error, r);
***************
*** 726,730 ****
              return 0;
          else {
!             log_printf(r->server, "unknown parameter %s to tag echo in %s",
                  tag, r->filename);
              rputs(error, r);
--- 726,730 ----
              return 0;
          else {
!             log_printf(r->server, "unknown parameter `%s' to tag echo in %s",
                  tag, r->filename);
              rputs(error, r);
***************
*** 797,801 ****
              return 0;
          else {
!             log_printf(r->server,"unknown parameter %s to tag config in %s",
                      tag, r->filename);
              rputs(error, r);
--- 797,801 ----
              return 0;
          else {
!             log_printf(r->server,"unknown parameter `%s' to tag config in %s",
                      tag, r->filename);
              rputs(error, r);
***************
*** 841,845 ****
      }
      else {
!         log_printf(r->server,"unknown parameter %s to tag %s in %s",
                  tag, directive, r->filename);
          rputs(error, r);
--- 841,845 ----
      }
      else {
!         log_printf(r->server,"unknown parameter `%s' to tag %s in %s",
                  tag, directive, r->filename);
          rputs(error, r);
***************
*** 1502,1506 ****
  #endif
          } else {
!             log_printf(r->server,"unknown parameter %s to tag if in %s",
                      tag, r->filename);
              rputs(error, r);
--- 1502,1506 ----
  #endif
          } else {
!             log_printf(r->server,"unknown parameter `%s' to tag if in %s",
                      tag, r->filename);
              rputs(error, r);
***************
*** 1539,1543 ****
  #endif
          } else {
!             log_printf(r->server,"unknown parameter %s to tag if in %s",
                      tag, r->filename);
              rputs(error, r);
--- 1539,1543 ----
  #endif
          } else {
!             log_printf(r->server,"unknown parameter `%s' to tag if in %s",
                      tag, r->filename);
              rputs(error, r);
%0
>Audit-Trail:
>Unformatted:


Reply via email to