Re: mod_alias/1155: RedirectMatch does not correctly deal with URLs which need to be escaped.

[Dean Gaudet]

The following reply was made to PR mod_alias/1155; it has been noted by GNATS.

From: Dean Gaudet <[EMAIL PROTECTED]>
To: Tim Newsome <[EMAIL PROTECTED]>
Subject: Re: mod_alias/1155: RedirectMatch does not correctly deal with URLs 
which need to be escaped.
Date: Wed, 24 Sep 1997 22:22:13 -0700 (PDT)

 
 Yup, this is a bug.  But I think this smaller patch accomplishes the same
 thing using existing functions.
 
 Dean
 
 Index: mod_alias.c
 ===================================================================
 RCS file: /export/home/cvs/apachen/src/modules/standard/mod_alias.c,v
 retrieving revision 1.24
 diff -u -r1.24 mod_alias.c
 --- mod_alias.c        1997/09/16 05:31:56     1.24
 +++ mod_alias.c        1997/09/25 05:20:48
 @@ -295,9 +295,13 @@
        int l;
  
        if (p->regexp) {
 -          if (!regexec(p->regexp, r->uri, p->regexp->re_nsub + 1, regm, 0))
 +          if (!regexec(p->regexp, r->uri, p->regexp->re_nsub + 1, regm, 0)) {
                found = pregsub(r->pool, p->real, r->uri,
                                p->regexp->re_nsub + 1, regm);
 +              if (found && doesc) {
 +                  found = escape_uri(r->pool, found);
 +              }
 +          }
        }
        else {
            l = alias_matches(r->uri, p->fake);