mod_dir/2015: In a direcotry index with IconsAreLInks, the link for the icon is separate from the link for the filename, and multiple spaces compressed in viewers. (being pedantic)

[Philip Kizer]

>Number:         2015
>Category:       mod_dir
>Synopsis:       In a direcotry index with IconsAreLInks, the link for the icon 
>is separate from the link for the filename, and multiple spaces compressed in 
>viewers. (being pedantic)
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    apache
>State:          open
>Class:          change-request
>Submitter-Id:   apache
>Arrival-Date:   Mon Mar 30 08:20:00 PST 1998
>Last-Modified:
>Originator:     [EMAIL PROTECTED]
>Organization:
apache
>Release:        1.2.6
>Environment:
IconsAreLinks are enabled and viewing from a text browser.
>Description:
When browsing a server-generated directory listing with a text-browser (such as
lynx) and IconsAreLinks is enabled, 'down' must be hit twice to go from file to
file.  I can see no reason to print out "</A>", and another 'anchor' between the
icon and filename.

Plus, (this may be a lynx bug), multiple spaces from an ALT="   " tag in a
directory listing are compressed to one space, so why not use " ? " instead of
"   " as the semantics from the viewing point are the same?
>How-To-Repeat:
http://cis.tamu.edu/systems/unix/source/ is a (currently, 1998-Mar-30) unpatched
example, repetition is trivial by enabling "IndexOptions IconsAreLinks" and
viewing with lynx or (presumably) other browser that allows keyboard navigation.
>Fix:
*** ../../apache_1.2.6/src/mod_dir.c    Fri Mar 27 09:49:39 1998
--- mod_dir.c   Mon Mar 30 09:26:47 1998
***************
*** 653,661 ****
                                   ar[x]->icon : d->default_icon),
!                      "\" ALT=\"[", (ar[x]->alt ? ar[x]->alt : "   "),
                       "]\">", NULL);
              }
-             if(dir_opts & ICONS_ARE_LINKS) 
-                 rputs("</A>", r);
  
!             rvputs(r," ", anchor, t2, NULL);
              if(!(dir_opts & SUPPRESS_LAST_MOD)) {
--- 653,665 ----
                                   ar[x]->icon : d->default_icon),
!                      "\" ALT=\"[", (ar[x]->alt ? ar[x]->alt : " ? "),
                       "]\">", NULL);
              }
  
!             if(dir_opts & ICONS_ARE_LINKS) {
!                 rvputs(r," ", t2, NULL);
!             }
!             else {
!                 rvputs(r," ", anchor, t2, NULL);
!             }
! 
              if(!(dir_opts & SUPPRESS_LAST_MOD)) {
%0
>Audit-Trail:
>Unformatted:
[In order for any reply to be added to the PR database, ]
[you need to include <[EMAIL PROTECTED]> in the Cc line ]
[and leave the subject line UNCHANGED.  This is not done]
[automatically because of the potential for mail loops. ]