[In order for any reply to be added to the PR database, ]
[you need to include <[EMAIL PROTECTED]> in the Cc line ]
[and leave the subject line UNCHANGED. This is not done]
[automatically because of the potential for mail loops. ]
Synopsis: The second arg to spawn_child_err() changed from "void (*)(void *)"
in 1.2 to "int(*)(void *)" in 1.3
State-Changed-From-To: open-analyzed
State-Changed-By: brian
State-Changed-When: Wed May 20 17:03:42 PDT 1998
State-Changed-Why:
>The second arg to spawn_child_err() changed from "void (*)(void *)" (in 1.2)
>to "int(*)(void *)" in (1.3). This should be reflected in compat.h so as
>to avoid unneccessary build warnings.
You mean warnings with older modules? That's going to be
inevitable, as yet another change was introduced into 1.3b7-dev
and will be there in 1.3.0: the prototype is now
API_EXPORT(int) ap_spawn_child_err(pool *, int (*)(void *, child_info *),
void *, enum kill_conditions,
FILE **pipe_in, FILE **pipe_out,
FILE **pipe_err);
This chance was necessary to gracefully (er, well, more
gracefully than the alternatives) allow for the different
child spawning interface in the Win32 API, which is now
being used in 1.3b7 to address some serious problems we've
had with MS's lackluster (so say the least) POSIX
implementation. So, third-party modules which use
spawn_child are going to have to be modified for 1.3
anyways. Also, all third-party modules should use
ap_spawn_child_err_buff to be completely safe on NT.
> Additionally, calls to spawn_child() should be changed to ap_spawn_child()
> for consistency with the conversion to the new namespace. This will
> require ap_spawn_child() be defined in alloc.h instead of spawn_child()
> (which should be only in compat.h). The current approach is non-intuitive
> and sets a bad example.
Would be nice to do, it's slightly more complex since spawn_child
is a macro but shouldn't be impossible. I'll see about doing
it.
