>Number: 3478
>Category: general
>Synopsis: bug in unsupported patch macaddr.patch
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: apache
>State: open
>Class: sw-bug
>Submitter-Id: apache
>Arrival-Date: Wed Dec 2 02:10:01 PST 1998
>Last-Modified:
>Originator: [EMAIL PROTECTED]
>Organization:
apache
>Release: 1.3
>Environment:
all
>Description:
during testing the apache contributed patch
http://www.apache.org/dist/contrib/patches/1.3/macaddr.patch
we discovered the following bug:
only the first ten (of twelve) digits of a MAC address
are checked, the last two are ignored
>How-To-Repeat:
>Fix:
Solution:
replace in section:
*** 291,296 ****
--- 359,406 ----
...
+ for(s = 0; s < 5; s++)
+ if(*ptr++ != *mac++)
+ return 0;
+ /*
+ ** A hit!
+ */
...
by
...
+ for(s = 0; s < 6; s++)
+ if(*ptr++ != *mac++)
+ return 0;
+ /*
+ ** A hit!
+ */
...
(s < 5 changed to s < 6 in loop)
("for"-loop now runs from 0 to 5 (= six times))
>Audit-Trail:
>Unformatted:
[In order for any reply to be added to the PR database, ]
[you need to include <[EMAIL PROTECTED]> in the Cc line ]
[and leave the subject line UNCHANGED. This is not done]
[automatically because of the potential for mail loops. ]
[If you do not include this Cc, your reply may be ig- ]
[nored unless you are responding to an explicit request ]
[from a developer. ]
[Reply only with text; DO NOT SEND ATTACHMENTS! ]
