>Number: 5178
>Category: other
>Synopsis: non-standard calls for mutli-thread access to passwords
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: apache
>State: open
>Class: change-request
>Submitter-Id: apache
>Arrival-Date: Thu Oct 21 08:50:00 PDT 1999
>Last-Modified:
>Originator: [EMAIL PROTECTED]
>Organization:
apache
>Release:
>Environment:
Linux 2.2.5-15 #1 Mon Apr 19 23:00:46 EDT 1999 i686 unknown
>Description:
defining MULTITREADING will cause the following compile errors:
apxs -o mod_auth_system.so -c mod_auth_system.c
gcc -DLINUX=2 -DUSE_HSREGEX -DUSE_EXPAT -I../lib/expat-lite -fpic
-DSHARED_MODULE -I/home/chas/apache/include -c mod_auth_system.c
mod_auth_system.c: In function `get_system_pw':
mod_auth_system.c:130: incompatible type for argument 2 of `getpwnam_r'
mod_auth_system.c:130: too few arguments to function `getpwnam_r'
mod_auth_system.c:130: warning: assignment makes pointer from integer without a
cast
apxs:Break: Command failed with rc=65536
make: *** [mod_auth_system.so] Error 1
defining MULTITREADING and SHADOW will cause the following compile errors:
apxs -o mod_auth_system.so -c mod_auth_system.c
gcc -DLINUX=2 -DUSE_HSREGEX -DUSE_EXPAT -I../lib/expat-lite -fpic
-DSHARED_MODULE -I/home/chas/apache/include -c mod_auth_system.c
mod_auth_system.c: In function `get_system_pw':
mod_auth_system.c:128: warning: assignment makes pointer from integer without a
cast
gcc -shared -o mod_auth_system.so mod_auth_system.o
>How-To-Repeat:
#define MULTITREADING and compile mod_auth_system
>Fix:
*** /home/chas/vslick/backup/mod_auth_system.c Mon Jul 12 02:25:04 1999
--- mod_auth_system.c Wed Oct 20 17:34:39 1999
***************
*** 77,85 ****
* take such that it had permission to access the system's shadow
* password file.
*/
! /* #define SHADOW */
! /* #define MULTITREADING */
#include "httpd.h"
--- 77,85 ----
* take such that it had permission to access the system's shadow
* password file.
*/
! #define SHADOW
! #define MULTITREADING
#include "httpd.h"
***************
*** 120,150 ****
static char *get_system_pw(request_rec *r, char *user)
{
char buff[MAX_STRING_LEN];
- #ifdef MULTITREADING
struct passwd *result;
struct passwd tmp;
#ifdef SHADOW
! result=getspnam_r(user,tmp,buff,MAX_STRING_LEN);
#else
! result=getpwnam_r(user,tmp,buff,MAX_STRING_LEN);
#endif
#else /* !MULTITREADING */
- struct passwd *result;
#ifdef SHADOW
result=getspnam(user);
#else /* !SHADOW */
result=getpwnam(user);
#endif /* SHADOW */
-
#endif /* MULTITREADING */
/* success ? */
- if (!result) {
- return NULL;
- };
if (!result->pw_passwd) {
#ifndef SHADOW
sprintf(buff,"no system password for %s; is system using shadow
passwords?", user);
--- 120,151 ----
static char *get_system_pw(request_rec *r, char *user)
{
char buff[MAX_STRING_LEN];
struct passwd *result;
+ #ifdef MULTITREADING
struct passwd tmp;
#ifdef SHADOW
! if(getspnam_r(user,&tmp,buff,MAX_STRING_LEN,&result)!=0)
! return NULL;
#else
! if(getpwnam_r(user,&tmp,buff,MAX_STRING_LEN,&result)!=0)
! return NULL;
#endif
#else /* !MULTITREADING */
#ifdef SHADOW
result=getspnam(user);
+ if (!result)
+ return NULL;
#else /* !SHADOW */
result=getpwnam(user);
+ if (!result)
+ return NULL;
#endif /* SHADOW */
#endif /* MULTITREADING */
/* success ? */
if (!result->pw_passwd) {
#ifndef SHADOW
sprintf(buff,"no system password for %s; is system using shadow
passwords?", user);
>Audit-Trail:
>Unformatted:
[In order for any reply to be added to the PR database, you need]
[to include <[EMAIL PROTECTED]> in the Cc line and make sure the]
[subject line starts with the report component and number, with ]
[or without any 'Re:' prefixes (such as "general/1098:" or ]
["Re: general/1098:"). If the subject doesn't match this ]
[pattern, your message will be misfiled and ignored. The ]
["apbugs" address is not added to the Cc line of messages from ]
[the database automatically because of the potential for mail ]
[loops. If you do not include this Cc, your reply may be ig- ]
[nored unless you are responding to an explicit request from a ]
[developer. Reply only with text; DO NOT SEND ATTACHMENTS! ]
