>Number: 5292
>Category: mod_auth-any
>Synopsis: mod_auth_digest.c - checking open() return value for wrong
>failure value
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: apache
>State: open
>Class: sw-bug
>Submitter-Id: apache
>Arrival-Date: Thu Nov 11 14:10:03 PST 1999
>Last-Modified:
>Originator: [EMAIL PROTECTED]
>Organization:
apache
>Release: Apache/1.3.10-dev
>Environment:
n/a
>Description:
result of open() call being check against wrong failure value
>How-To-Repeat:
compile mod_auth_digest.c with DEV_RANDOM defined
>Fix:
--- mod_auth_digest.c.~1~ Sun Sep 19 20:13:23 1999
+++ mod_auth_digest.c Thu Nov 11 14:49:28 1999
@@ -317,7 +317,7 @@
#ifdef DEV_RANDOM
#define XSTR(x) #x
#define STR(x) XSTR(x)
- if ((rnd = open(STR(DEV_RANDOM), O_RDONLY)) == NULL) {
+ if ((rnd = open(STR(DEV_RANDOM), O_RDONLY)) == -1) {
ap_log_error(APLOG_MARK, APLOG_CRIT, s,
"Digest: Couldn't open " STR(DEV_RANDOM));
exit(EXIT_FAILURE);
>Audit-Trail:
>Unformatted:
[In order for any reply to be added to the PR database, you need]
[to include <[EMAIL PROTECTED]> in the Cc line and make sure the]
[subject line starts with the report component and number, with ]
[or without any 'Re:' prefixes (such as "general/1098:" or ]
["Re: general/1098:"). If the subject doesn't match this ]
[pattern, your message will be misfiled and ignored. The ]
["apbugs" address is not added to the Cc line of messages from ]
[the database automatically because of the potential for mail ]
[loops. If you do not include this Cc, your reply may be ig- ]
[nored unless you are responding to an explicit request from a ]
[developer. Reply only with text; DO NOT SEND ATTACHMENTS! ]