marc 98/04/18 14:38:00
Modified: src CHANGES
src/main http_core.c
Log:
If an explict handler is set for a file yet we end up in the default
handler anyway, something went wrong somewhere so we should tell
people about it. The old behaviour was silently processing the
request with the default handler, giving the user no warning that
their configuration to use a specific handler is being ignored.
Reviewed by: Ben Laurie, Dean Gaudet, Martin Kraemer
Revision Changes Path
1.773 +5 -0 apache-1.3/src/CHANGES
Index: CHANGES
===================================================================
RCS file: /export/home/cvs/apache-1.3/src/CHANGES,v
retrieving revision 1.772
retrieving revision 1.773
diff -u -r1.772 -r1.773
--- CHANGES 1998/04/18 10:54:54 1.772
+++ CHANGES 1998/04/18 21:37:54 1.773
@@ -1,5 +1,10 @@
Changes with Apache 1.3b7
+ *) If a specific handler is set for a file yet the request still
+ ends up being handled by the default handler, log an error
+ message before handling it. This catches things such as trying
+ to use SSIs without mod_include enabled. [Marc Slemko]
+
*) Fix error logging for the startup case where ap_log_error() still uses
stderr as the target. Now the default log level is honored here, too.
[Ralf S. Engelschall]
1.185 +6 -0 apache-1.3/src/main/http_core.c
Index: http_core.c
===================================================================
RCS file: /export/home/cvs/apache-1.3/src/main/http_core.c,v
retrieving revision 1.184
retrieving revision 1.185
diff -u -r1.184 -r1.185
--- http_core.c 1998/04/18 11:53:35 1.184
+++ http_core.c 1998/04/18 21:37:58 1.185
@@ -2049,6 +2049,12 @@
caddr_t mm;
#endif
+ if (r->handler) {
+ ap_log_error(APLOG_MARK, APLOG_NOERRNO|APLOG_WARNING,
+ r->server, "handler \"%s\" not found, using default "
+ "handler for: %s", r->handler, r->filename);
+ }
+
/* This handler has no use for a request body (yet), but we still
* need to read and discard it if the client sent one.
*/
