dgaudet 98/08/19 21:11:34
Modified: src/support ab.c
Log:
note a few bugs
Revision Changes Path
1.13 +13 -1 apache-1.3/src/support/ab.c
Index: ab.c
===================================================================
RCS file: /export/home/cvs/apache-1.3/src/support/ab.c,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -r1.12 -r1.13
--- ab.c 1998/08/20 04:07:45 1.12
+++ ab.c 1998/08/20 04:11:33 1.13
@@ -83,6 +83,18 @@
**
*/
+/*
+ * BUGS:
+ *
+ * - uses strcpy/etc.
+ * - has various other poor buffer attacks related to the lazy parsing of
+ * response headers from the server
+ * - doesn't implement much of HTTP/1.x, only accepts certain forms of
+ * responses
+ * - (performance problem) heavy use of strstr shows up top in profile
+ * only an issue for loopback usage
+ */
+
#define VERSION "1.2"
/* -------------------------------------------------------------------- */
@@ -480,7 +492,7 @@
*q = 0;
}
- /* FIXME: this parsing isn't even remotely HTTP compliant...
+ /* XXX: this parsing isn't even remotely HTTP compliant...
* but in the interest of speed it doesn't totally have to be,
* it just needs to be extended to handle whatever servers
* folks want to test against. -djg */
