On 25 March 2014 22:15, Kevin Brubeck Unhammer <[email protected]> wrote: > "Jim O'Regan" <[email protected]> writes: > >> On 25 March 2014 13:14, Kevin Brubeck Unhammer <[email protected]> wrote: > > [...] > >>> While on the subject of things that could be sorted out before a >>> release, why are some XML validation files .rng and some .dtd? And why >>> does apertium include files for lttoolbox formats? >>> >>> lttoolbox: >>> - dix.dtd >>> - dix.rng acx.rng >>> >>> apertium: >>> - dix.dtd format.dtd interchunk.dtd modes.dtd postchunk.dtd tagger.dtd >>> transfer.dtd >>> - acx.rng modes.rng transfer.rng >>> >>> (I would prefer to rm {dix,acx}.* from apertium, and otherwise either >>> have one format for all files, or both formats for all files.) >> >> Because the validators are built from Apertium's Makefile. Which would >> also fit the 'why...' pattern, but 'apertium-validate-dictionary' is >> slightly more user-friendly than 'lttoolbox-validate-dix' (it matches >> the intention, rather the details of the source package). > > Ah, of course. > > However, trunk/apertium/apertium/Makefile.am already assumes that > lttoolbox is installed to the same prefix, e.g. it does stuff like
Yeah... but more fundamentally, Apertium can't build without lttoolbox, so I think it's safe to depend on it :) > > @echo "APERTIUM_PATH=\"$(prefix)/bin\"" >>$@ > @echo "LTTOOLBOX_PATH=\"$(prefix)/bin\"" >>$@ > > So it should be fine to just change > > @echo "$(XMLLINT) --dtdvalid $(apertiumdir)/dix.dtd --noout \$$FILE1 && > exit 0;" >> $@ > > to > > @echo "$(XMLLINT) --dtdvalid $(prefix)/share/lttolbox/dix.dtd --noout > \$$FILE1 && exit 0;" >> $@ > > > (Though a more Right way would be to get lttoolbox's prefix from > pkg-config.) > LGTM. > > If that path is not changed, the dix.dtd in apertium should at least be > updated to match the one in lttoolbox … I'd prefer the 'depend on lttoolbox' route. -- <Sefam> Are any of the mentors around? <jimregan> yes, they're the ones trolling you ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech _______________________________________________ Apertium-stuff mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/apertium-stuff
