I'm a strong proponent of everything being portable C++, but this is a collection of scripts that call other C++ tools. It could be done in C++, but that's less flexible. And given that these are developer-oriented tools that will never be seen by end users, it's not such a big loss - we already force developers to be on Linux/Unix systems.
Even on Windows, WSL https://docs.microsoft.com/windows/wsl is so damn useful. I've been using it since it launched, and it works. Much better than Cygwin - it's an actual native cmdline Linux distro (e.g. Ubuntu LTS) with the normal package manager, but without the overhead of virtualization. So in this case, I could say leave the code as-is, a mix of shell scripts and Python 3. The Python scripts are all lacking the shebang, though. They all need: #!/usr/bin/env python3 Regarding streamparser, yes you should reuse our existing packages. Use libraries, use packages, don't duplicate code. As for cleanstream, I was sure that had been packaged, but seems not. I'll put that on the list... -- Tino Didriksen On Wed, 14 Aug 2019 at 23:55, Amr Mohamed Hosny Anwar < amr.ke...@eng.asu.edu.eg> wrote: > The pull request on Github can be found here: > https://github.com/apertium/lttoolbox/pull/55 > > The main code organisation points that needs reviewing/attention are: > * How can we encapsulate pure shell scripts into lttoolbox? > * Should we port vanilla python scripts to shell or C++ scripts? > The supervised script is currently implemented in python. > The constraint grammar script also depends on the supervised one so python > is one of its dependencies. > I am much more proficient in C++ coding than shell scripting. > * Should apertium-streamparser be used for parsing tagged corpora in the > form "^surface/analysis1$" instead of re-implementing parsing methods > (which is the case currently)? > * Can we use vanilla python scripts for models evaluation? > * How to update the automake file so that the weighting scripts can be > used as all the other lt-* commands? > * How to avoid using the apertium-cleanstream script ( > http://svn.code.sf.net/p/apertium/svn/trunk/apertium-tools/apertium-cleanstream/apertium-cleanstream.cc > )? > Is there other lightweight alternatives? >
_______________________________________________ Apertium-stuff mailing list Apertium-stuff@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/apertium-stuff
