On 01/12/2012 10:08 AM, Steve Beattie wrote: > The coredump checkcorefile() function did not properly quote the _known > variable (set when the tests are marked as expected failures) when > the expectation was that the testcase would produce a corefile. This > would result in a failed testcase reporting XFAIL incorrectly. > Acked-by: John Johansen <[email protected]>
> --- > tests/regression/apparmor/coredump.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > Index: b/tests/regression/apparmor/coredump.sh > =================================================================== > --- a/tests/regression/apparmor/coredump.sh > +++ b/tests/regression/apparmor/coredump.sh > @@ -35,11 +35,11 @@ checkcorefile() > fi > > if [ "$requirement" = "yes" -a "$_corefile" = "no" ] ; then > - if [ -n $_known ] ; then > + if [ -n "$_known" ] ; then > echo -n "XFAIL: " > fi > echo "Error: corefile expected but not present - $2" > - if [ -z $_known ] ; then > + if [ -z "$_known" ] ; then > cat $profile > testfailed > fi > > > -- AppArmor mailing list [email protected] Modify settings or > unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/apparmor > -- AppArmor mailing list [email protected] Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/apparmor
