On Tue, Nov 20, 2012 at 08:39:44PM -0800, John Johansen wrote: > -ESTALE used to be incorrectly used to indicate a disconnected path, when > name lookup failed. This was fixed in commit e1b0e444 to correctly return > -EACCESS, but the error to failure message mapping was not correctly updated > to reflect this change. > > Signed-off-by: John Johansen <[email protected]> Acked-by: Steve Beattie <[email protected]>
As an aside, I remembered asking a question about needing to keep
the reverse patch around for older kernels that returned -ESTALE, and
found it in the archives. Turned out I had already acked this patch
and patches 1 and 2 the prior time you sent them to the list. Any
chance you can hang on to the acked-by statements or is that not
possible in git?
> ---
> security/apparmor/path.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/apparmor/path.c b/security/apparmor/path.c
> index e91ffee..35b394a 100644
> --- a/security/apparmor/path.c
> +++ b/security/apparmor/path.c
> @@ -174,7 +174,7 @@ static int get_name_to_buffer(struct path *path, int
> flags, char *buffer,
> if (info && error) {
> if (error == -ENOENT)
> *info = "Failed name lookup - deleted entry";
> - else if (error == -ESTALE)
> + else if (error == -EACCES)
> *info = "Failed name lookup - disconnected path";
> else if (error == -ENAMETOOLONG)
> *info = "Failed name lookup - name too long";
--
Steve Beattie
<[email protected]>
http://NxNW.org/~steve/
signature.asc
Description: Digital signature
-- AppArmor mailing list [email protected] Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/apparmor
