On 06/25/2013 02:14 PM, John Johansen wrote: > On 06/24/2013 11:52 AM, Seth Arnold wrote: >> On Sun, Jun 23, 2013 at 04:23:14PM -0700, Tyler Hicks wrote: >>> From: John Johansen <[email protected]> >>> >>> Return the total size of the security context on success >>> as documented. >>> >>> Signed-off-by: John Johansen <[email protected]> >> >> The implementation of this idea is fine. But the *size parameter is >> already being updated with the length, which seems sufficient to me. >> > ah crud, can't give an Acked-by: to my own patch > > sarnold this fixes the interface, and we are not changing a shipped > api > >
so I have been reminded that while this interface shipped its backend was not hooked up and it never worked so no one, including us as a project have used it. And we already broke the abi by adding the mode bits. As we can discuss changing this. I would rather have the size returned, either by returning -1, and the size in the parameter or by returning, size, and -size on error. I don't particularly care for just dropping the returning the needed buffer size. -- AppArmor mailing list [email protected] Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/apparmor
