On Thu, Aug 08, 2013 at 05:41:31PM -0700, John Johansen wrote: > Provide userspace the ability to validate what policy is loaded via > an exported crypto hash value. > > Signed-off-by: John Johansen <[email protected]>
Acked-by: Seth Arnold <[email protected]> ... with one suggestion, either way: > +static int aa_fs_seq_hash_show(struct seq_file *seq, void *v) > +{ > + unsigned char *string = seq->private; > + unsigned int i; > + > + if (string) { > + for (i = 0; i < aa_hash_size(); i++) > + seq_printf(seq, "%.2x", string[i]); > + seq_printf(seq, "\n"); > + } > + > + return 0; > +} It might be kind to hoist aa_hash_size() out of the loop if gcc doesn't do that for us. (It probably can't.) Thanks
signature.asc
Description: Digital signature
-- AppArmor mailing list [email protected] Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/apparmor
