On Wed, Sep 11, 2013 at 01:42:30AM -0700, Tyler Hicks wrote:
> Reuse free_cod_entries() when freeing merged file entries in
> process_file_entries().
> 
> Signed-off-by: Tyler Hicks <[email protected]>

Nice catch. This actually fixes one of the memory leaks that I had not
yet seen and tracked down because the valgrind run took too long. You
can see get caught in action by doing the following (without and with
your patch applied):

  cd parser ; make clean all && make -C tst gen_xtrans
  valgrind --leak-check=full ./apparmor_parser -Q -I tst/simple_tests 
tst/simple_tests/xtrans/simple_bad_x_mods_first_35.sd

Acked-by: Steve Beattie <[email protected]>

-- 
Steve Beattie
<[email protected]>
http://NxNW.org/~steve/

Attachment: signature.asc
Description: Digital signature

-- 
AppArmor mailing list
[email protected]
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/apparmor

Reply via email to