On Fri, Jul 11, 2014 at 03:35:32PM -0700, Seth Arnold wrote: > On Fri, Jul 11, 2014 at 03:24:29PM -0700, Steve Beattie wrote: > > This patch fixes some memory leaks in the libapparmor log parsing functions, > > specifically around handling records obtained from syslog and records > > containing network addresses. > > > > Bug: https://bugs.launchpad.net/bugs/1340927 > > Signed-off-by: Steve Beattie <[email protected]> > > Wow, nice catch and fast debugging.
Valgrind and existing test cases are a heck of a thing. Would be nice to hook up an automated target that integrates valgrind into libapparmor's make check, at least optionally. Also, generating coverage information would be useful, too. Even with this fix, there are a few testcases that valgrind reports leaks; they're specifically cases that are invalid parse records. I have not tracked down exactly what's going wrong there. -- Steve Beattie <[email protected]> http://NxNW.org/~steve/
signature.asc
Description: Digital signature
-- AppArmor mailing list [email protected] Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/apparmor
