On Thu, Aug 07, 2014 at 04:03:35PM -0700, Seth Arnold wrote: > On Wed, Aug 06, 2014 at 05:32:46AM -0700, [email protected] wrote: > > Signed-off-by: John Johansen <[email protected]> > > I found a bug; it and other comments inline.
Ah, I see you already found and fixed it in a later patch. That leaves just one question from this patch outstanding: > > --- /dev/null > > +++ 2.9-test/parser/network.c > > @@ -0,0 +1,336 @@ > > +/* > > + * Copyright (c) 2014 > > + * Canonical, Ltd. (All rights reserved) > > + * > > + * This program is free software; you can redistribute it and/or > > + * modify it under the terms of version 2 of the GNU General Public > > + * License published by the Free Software Foundation. > > + * > > + * This program is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > + * GNU General Public License for more details. > > + * > > + * You should have received a copy of the GNU General Public License > > + * along with this program; if not, contact Novell, Inc. or Canonical > > + * Ltd. > > + */ > > + > > +#include <stdlib.h> > > +#include <string.h> > > +#include <sys/apparmor.h> > > + > > +#include <iomanip> > > +#include <string> > > Is it kosher to include both string.h and string? > I assume if it were really bad, the compiler would let you know. Acked-by: Seth Arnold <[email protected]> thanks:wq
signature.asc
Description: Digital signature
-- AppArmor mailing list [email protected] Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/apparmor
