Hello,

Am Donnerstag, 14. August 2014 schrieb Aaron Lewis:
> 1. A comma is needed even if it's the last line before the ending '}'
>     -- That's a change

I never tested a profile without a comma in the last rule, so I don't 
know if it was ever optional ;-)

> 2. The error message does not show which line has the syntax error  --
> All I see is a stack trace, a python one, no line-number of the
> parsed rule fil

The error message says:
    Syntax Error: Missing '}'. Reached end of file %s while 
    inside profile %s

Isn't "Reached end of file" obvious enough?

We can easily add the line number if you think it's useful - somethink 
like   "file %s (line %s)"

We should also extend the error message to
    Syntax Error: Missing '}' or ','.   [...]
to indicate that it can also be a missing comma.

I'll send a patch after we have decided what to add to the error 
message ;-)


Regards,

Christian Boltz
-- 
[Passwörter] Ich suche nach einem Mittelweg zwischen maximaler
Sicherheit und Zumutbarkeit für den Benutzer (ein Pferd mit Hufen,
dem unsere Admin-Tastaturen viel zu klein sind :-)).
[Manfred Rebentisch in suse-linux]


-- 
AppArmor mailing list
[email protected]
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/apparmor

Reply via email to