On Fri, Aug 15, 2014 at 12:20:40PM -0700, [email protected] wrote: > Signed-off-by: John Johansen <[email protected]> > Acked-by: Seth Arnold <[email protected]>
Missed previously, the prototype for this function was introduced in the
previous patch.
> +const struct network_tuple *net_find_mapping(const char *family,
> + const char *type,
> + const char *protocol)
> {
>
> +struct network_tuple {
> + const char *family_name;
> + unsigned int family;
> + const char *type_name;
> + unsigned int type;
> + const char *protocol_name;
> + unsigned int protocol;
> +};
It's not introduced with this patch but I wonder if this structure should
be re-ordered. On a 64-bit platform, will those pointers by aligned along
8-byte boundaries leaving 4-byte holes? My first impression is that this
stores 36 bytes of data in 48 bytes of struct on a 64-bit platform.
Thanks
signature.asc
Description: Digital signature
-- AppArmor mailing list [email protected] Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/apparmor
