On Wed, Sep 10, 2014 at 06:22:45PM -0700, Steve Beattie wrote: > On Tue, Sep 09, 2014 at 08:21:00PM -0700, Seth Arnold wrote: > > Thanks for forwarding this along; the #include <sys/sysctl.h> dates from > > the ancient times, probably Linux 2.0 or 2.2 days. > > > > The attached patch removes the header unconditionally; the parser builds > > and passes "make check USE_SYSTEM=1" on my Ubuntu 14.04 LTS laptop. > > > > I propose this patch for trunk: > > > > Signed-off-by: Seth Arnold <[email protected]> > > > > === modified file 'parser/parser_main.c' > > --- parser/parser_main.c 2014-09-03 20:22:26 +0000 > > +++ parser/parser_main.c 2014-09-10 03:06:44 +0000 > > @@ -35,7 +35,6 @@ > > > > #include <unistd.h> > > #include <limits.h> > > -#include <sys/sysctl.h> > > #include <sys/types.h> > > #include <sys/stat.h> > > #include <sys/apparmor.h> > > Seeing that the debian apparmor packaging team pulled in this patch into > their 2.8 based package, I'm nominating this for the 2.8 branch.
Makes sense. > I should also explain that we have another use of sysctl() in the > regression tests, but until the only kernels we support are ones > that have dropped sysctl() entirely, we should keep that in place > to continue ensuring that we mediate it (as well as the /proc/sys/ > based implementation). Completely agreed that the tests are another matter. (Though they may need updating to run only on !x32 platforms.) Thanks
signature.asc
Description: Digital signature
-- AppArmor mailing list [email protected] Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/apparmor
