On 2015-01-13 11:33:10, Steve Beattie wrote: > utils: fix python install for rule/ subdirectory > > For reasons that are unclear to me, python's setuptools doesn't > install recursively from a directory, meaning that on make install, > the new Rules/Ruleset classes were not being installed. This patch > causes the rule subdirectory to be included. > > Bug: https://bugs.launchpad.net/bugs/1407437 > > Signed-off-by: Steve Beattie <[email protected]>
I don't have much experience here but I see that setuptools provides find_packages() which may be a little more future proof than manually adding new packages to the list. https://pythonhosted.org/setuptools/setuptools.html#using-find-packages However, I think what you have here is perfectly acceptable and gets my ack. Acked-by: Tyler Hicks <[email protected]> > --- > utils/python-tools-setup.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: b/utils/python-tools-setup.py > =================================================================== > --- a/utils/python-tools-setup.py > +++ b/utils/python-tools-setup.py > @@ -81,7 +81,7 @@ setup (name='apparmor', > license='GPL-2', > cmdclass={'install': Install}, > package_dir={'apparmor': 'staging'}, > - packages=['apparmor'], > + packages=['apparmor', 'apparmor.rule'], > py_modules=['apparmor.easyprof'] > ) > > -- > Steve Beattie > <[email protected]> > http://NxNW.org/~steve/ > -- > AppArmor mailing list > [email protected] > Modify settings or unsubscribe at: > https://lists.ubuntu.com/mailman/listinfo/apparmor
signature.asc
Description: Digital signature
-- AppArmor mailing list [email protected] Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/apparmor
