On 2015-03-26 18:41:46, Tyler Hicks wrote:
> On 2015-03-26 16:47:56, Tyler Hicks wrote:
> > This patch set modifies the new API functions to use the openat(2) style of 
> > a
> > dirfd and path for specifying a file.
> > 
> > The major downside of the patch set is that it may weaken the usefulness of
> > logging since path may be a single component. However, that can be 
> > addresses in
> > a future patch where the path of the dirfd can be determined by reading the
> > target of /proc/self/fd/%d, if desired.
> > 
> > Even if we don't move the new APIs over to the openat(2) style, I think that
> > the first 3 patches in the patch set are valid cleanups which simplify the 
> > code
> > are are worth merging either way.
> 
> Bah! There are memleaks introduced by this patch set. Please hold off on
> reviews until I get them ironed out and send a v2. Sorry.

Ok, the fixup patch that I sent for patch 1/6 fixes all the memleaks.

Tyler

Attachment: signature.asc
Description: Digital signature

-- 
AppArmor mailing list
[email protected]
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/apparmor

Reply via email to