On 06/16/2015 01:25 PM, Christian Boltz wrote:
> Hello,
> 
> Am Dienstag, 16. Juni 2015 schrieb Tyler Hicks:
>> On 2015-06-16 13:14:15, Christian Boltz wrote:
> 
>>> BTW: The function definition is
>>>
>>>     int _aa_is_blacklisted(const char *name, const char *path)
>>>
>>> but "path" is never used inside the function. Is this intentional?
>>
>> Nice catch. No, it isn't intentional. I'll fix it in a follow up patch
>> and will include the rational in the commit message.
> 
> Thanks!
> 
>> There's an additional follow up patch that I'll also be sending that
>> prevents crazy exceptions from being raised by
>> LibAppArmor._aa_is_blacklisted() in some situations.
>>
>> Do I have your ACK on this patch?
> 
> With my limited C knownledge, I hesitate to ack any C or C++ patches 
> that do more than updating a comment or fixing a typo in a string ;-)
> 
> However, this patch looks simple enough, so I'll accept the risk ;-) and 
> say
>     Acked-by: Christian Boltz <[email protected]>
> 
If that wasn't enough

Acked-by: John Johansen <[email protected]>


-- 
AppArmor mailing list
[email protected]
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/apparmor

Reply via email to