On Thu, Aug 27, 2015 at 01:44:58PM -0700, Steve Beattie wrote: > It looks like the parser never drops it's reference to the policy cache > object. This patch looks to fix the issue: > > Signed-off-by: Steve Beattie <[email protected]> > --- > parser/parser_main.c | 1 + > 1 file changed, 1 insertion(+) > > Index: b/parser/parser_main.c > =================================================================== > --- a/parser/parser_main.c > +++ b/parser/parser_main.c > @@ -992,6 +992,7 @@ int main(int argc, char *argv[]) > > if (ofile) > fclose(ofile); > + aa_policy_cache_unref(policy_cache); > > return last_error; > }
While this patch does look correct in itself, I'm curious if this means the aa_policy_cache_unref() function has not been as tested as we thought -- it might not have been run in production if it hasn't been used here. The other uses look conditional -- and perhaps only in uncommon situations. Acked-by: Seth Arnold <[email protected]> Thanks
signature.asc
Description: Digital signature
-- AppArmor mailing list [email protected] Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/apparmor
