Hello,
Am Montag, 14. September 2015 schrieb John Johansen:
> Now that we build using the C++ compiler use CXXFLAGS
>
> Signed-off-by: John Johansen <[email protected]>
This patch is a bit beyond my compiler knownledge, but since most of the
changes are about renaming CFLAGS to CXXFLAGS and similar stuff, I'll
risk doing the review nevertheless. That's still better than a timeout ;-)
The most interesting (aka non-obvious on the first view) change was:
> diff --git a/parser/libapparmor_re/Makefile
> b/parser/libapparmor_re/Makefile index c8d9db6..1c341a5 100644
> --- a/parser/libapparmor_re/Makefile
> +++ b/parser/libapparmor_re/Makefile
...
> -CFLAGS ?= -g -Wall -O2 ${EXTRA_CFLAGS} -std=gnu++0x
> -CXXFLAGS := ${CFLAGS} ${INCLUDE_APPARMOR}
> +CXXFLAGS ?= -g -Wall -O2 ${EXTRA_CXXFLAGS} -std=gnu++0x
You dropped ${INCLUDE_APPARMOR} from CXXFLAGS here...
> @@ -28,6 +27,7 @@ libapparmor_re.a: $(OBJS)
> %.o: %.cc $(HDRS)
> + $(CXX) $(CPPFLAGS) $(CXXFLAGS) $(INCLUDE_APPARMOR) -c $< -o $@
... and add it to the compiler call here, so in summary the patch looks
fine :-)
Acked-by: Christian Boltz <[email protected]>
Regards,
Christian Boltz
--
> warum bekomme ich eigentlich nie ne Antwort wenn ich in der liste
> was reinschreibe. Mögt ihr mich nicht??
nur leicht gesalzen...
[> Thomas Leist und Thilo Alfred Bätzig in suse-linux]
--
AppArmor mailing list
[email protected]
Modify settings or unsubscribe at:
https://lists.ubuntu.com/mailman/listinfo/apparmor
