On 2016-01-06 12:54:32, Christian Boltz wrote: > Hello, > > Am Dienstag, 5. Januar 2016 schrieb Tyler Hicks: > > Order the DIRS variable according to build order. This allows the DIRS > > variable to be iterated over to build libapparmor, binutils, utils, > > parser, etc., without having to reorder the list. > > > > Signed-off-by: Tyler Hicks <[email protected]> > > --- > > Makefile | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/Makefile b/Makefile > > index f7907cd..5a9ba73 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -8,13 +8,13 @@ all: > > COMMONDIR=common > > include ${COMMONDIR}/Make.rules > > > > -DIRS=parser \ > > - profiles \ > > - utils \ > > +DIRS=libraries/libapparmor \ > > binutils \ > > - libraries/libapparmor \ > > + utils \ > > + parser \ > > Can you change that order a bit to make it more useful if we ever come > up with a global "make test"? > > The utils tests nowadays use the parser simple_tests to make sure > parsing profiles doesn't result in unexpected results (valid vs. invalid > syntax). > > However, lots of the simple_tests are autogenerated in the parser "make > test" run, so that should be done first to ensure the utils test can test > everything. > > So long story short, please change the patch to > > ... > + parser \ > + utils \ > ... > > With that changed, > Acked-by: Christian Boltz <[email protected]>
Good idea. I've made the change in my local branch. Tyler > > > Regards, > > Christian Boltz > -- > Dieser Indizierungsmurks. Semantikgefuckel, dass das System > unbenutzbar macht. > Aber gut, dass man zwei Knie hat, in die man sich schießen kann. > [Lars Müller in opensuse-de] > -- > AppArmor mailing list > [email protected] > Modify settings or unsubscribe at: > https://lists.ubuntu.com/mailman/listinfo/apparmor
signature.asc
Description: Digital signature
-- AppArmor mailing list [email protected] Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/apparmor
