Hello,

Am Mittwoch, 21. September 2016, 12:39:14 CEST schrieb Steve Beattie:
> On Tue, Sep 20, 2016 at 09:54:02PM +0200, Christian Boltz wrote:

> > I get similar py2 failures in AaTest_create_new_profile, so you
> > might
> > want to apply your patch to this class also. Consider this
> > 
> >     Pre-Acked-by: Christian Boltz <appar...@cboltz.de>
> 
> Interesting, I'm unable to reproduce it for that test class. Do you
> have example output?

The FileRule series [15/38] patch adds using fake_ldd to 
AaTest_create_new_profile, so it's not surprising that you don't see it 
yet ;-)

With the patch applied, you'll get

======================================================================
ERROR: test_1 (__main__.AaTest_create_new_profile)
test 'foo bar'
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/cb/apparmor/HEAD-clean/utils/test/common_test.py", line 88, in 
stub_test
    self._run_test(test_data, expected)
  File "test-aa.py", line 126, in _run_test
    profile = create_new_profile(program)
  File "/home/cb/apparmor/HEAD-clean/utils/apparmor/aa.py", line 529, in 
create_new_profile
    handle_binfmt(local_profile[localfile], localfile)
  File "/home/cb/apparmor/HEAD-clean/utils/apparmor/aa.py", line 389, in 
handle_binfmt
    reqs = get_reqs(path)
  File "/home/cb/apparmor/HEAD-clean/utils/apparmor/aa.py", line 383, in 
get_reqs
    raise AppArmorBug('%(ldd)s %(file)s failed with exit status %(ret)s' % 
{'ldd': ldd, 'file': file, 'ret': ret})
AppArmorBug: /usr/bin/ldd /tmp/aa-test-GmA1yC/script failed with exit status 1

======================================================================
FAIL: test_0 (__main__.AaTest_create_new_profile)
test '#!/bin/bash
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/cb/apparmor/HEAD-clean/utils/test/common_test.py", line 88, in 
stub_test
    self._run_test(test_data, expected)
  File "test-aa.py", line 130, in _run_test
    '/AATest/lib64/libtinfo.so.* mr,', '/AATest/lib64/libc.so.* mr,', 
'/AATest/lib64/libdl.so.* mr,', '/AATest/lib64/libreadline.so.* mr,', 
'/AATest/lib64/ld-linux-x86-64.so.* mr,' })
AssertionError: Items in the second set but not the first:
'/AATest/lib64/libdl.so.* mr,'
'/AATest/lib64/libreadline.so.* mr,'
'/AATest/lib64/ld-linux-x86-64.so.* mr,'
'/AATest/lib64/libc.so.* mr,'
'/AATest/lib64/libtinfo.so.* mr,'

----------------------------------------------------------------------


Since this is caused by the FileRule series, I'll send an updated [15/38] 
patch. I need to do that anyway because your little commit breaks 
applying this patch :-/ - but on the positive side, I can add skipping
that test in py2 while on it.

Note to myself: Never send out acks to little patches while a big patch 
series is pending. Especially if this big series should be reviewed 
since a month!


Regards,

Christian Boltz
-- 
> Again, apt is dead, there is no maintainership upstream -- let's
> leave this sinking ship NOW.
Don't forget we are on the sea and not at the harbour.
So leaving the ship will end in the water as long as the new ship is
not ready.   [> Christoph Thiel and Eberhard Moenkeberg in opensuse]

Attachment: signature.asc
Description: This is a digitally signed message part.

-- 
AppArmor mailing list
AppArmor@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/apparmor

Reply via email to