Hello, Am Freitag, 14. Oktober 2016, 12:16:52 CEST schrieb Steve Beattie: > On Fri, Oct 14, 2016 at 12:43:19AM +0200, Christian Boltz wrote: > > seen_events is a global variable in aa.py that gets increased at > > several places, but isn't used (read or printed) anywhere. Since I > > can't imagine how it could become useful, simply drop it. > > I've no problem dropping this variable if we're not using it anywhere. > > That said, I know previously in the development of the perl version > of the tools, there was some experimentation with showing things like > progress bars or information like e.g. "37 of 146 pending rejections > would be covered by adding this rule". I think there's a place for > indicators that show contextual information about the current run of > whatever tool is being used, and this variable may have been added > as a data gathering element to support that.
That sounds like an interesting idea, but I doubt a simple counter (like the two I dropped) would provide this information ;-) What you propose would be more or less easy when adding the specific rule type (like a file rule for file events) - we'd just need to check is_covered() of the pending file events . Things become slightly more interesting (and possibly a bit slower) when counting for an include file because we'd need to check all event types, not only file events, and check against all rules in the include. I'm not saying it's impossible, "just" more interesting ;-) Feel free to open a feature request to make sure this idea doesn't get lost, but I probably don't need to mention that we have more urgent things on the TODO list ;-) Regards, Christian Boltz  Currently we don't delete the events from the log queue because the for loop makes sure to hit them only once, but that would be an easy fix. -- > [qpopper] Jepp. Den einzurichten, dauert max. 10 Min. Und ist absolut > pflegeleicht. ;) Hm... womit verbringst Du denn die letzten neun Minuten? Oder kommt hier ein 286er zum Einsatz? [> Michael Raab und Andreas Feile in suse-linux]
Description: This is a digitally signed message part.
-- AppArmor mailing list AppArmor@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/apparmor