I just checked your patch. In general it looks very good :-)
Some minor nitpicking:
In several profiles, the permissions are adjusted in "tabular style", so it
would be nice to adjust the whitespace in the lines you modified in
- etc.cron.daily.slocate.cron profile
- sbin.rpc.statd
- usr.NX.bin.nxclient
- usr.lib.postfix.local
- usr.sbin.xinetd (please also fix the whitespace for the xinetd.pid rule while
on it ;-)
In the usr.sbin.sshd profile, please change /{,usr/}/sbin/nologin to /{usr/,}
to match the other rules.
Given the amount of changes, I'd like to have someone else to cross-check at
least the changes in the abstractions (which are the only part where some
(hopefully superfluous) permissions were removed.
--
https://code.launchpad.net/~intrigeri/apparmor/usrmerge/+merge/312409
Your team AppArmor Developers is requested to review the proposed merge of
lp:~intrigeri/apparmor/usrmerge into lp:apparmor.
--
AppArmor mailing list
[email protected]
Modify settings or unsubscribe at:
https://lists.ubuntu.com/mailman/listinfo/apparmor
