Hello, I know this is already in bzr, but I have some minor nitpicking nevertheless ;-)
Am Mittwoch, 6. September 2017, 22:09:05 CEST schrieb John Johansen: > Update the tests to test whether the kernel and parser support domain > transitions on pivot_root. > --- a/tests/regression/apparmor/pivot_root.sh > +++ b/tests/regression/apparmor/pivot_root.sh > +if [ "$(kernel_features_istrue namespaces/pivot_root)" != "true" ] ; then > + echo " kernel does not support pivot_root domain transitions > skipping tests ..." This reads as "kernel does not support [...] tests" while it's probably meant as "kernel does not support [...] transitions, therefore skipping tests". Please change "transitions skipping" to "transitions, skipping" or "transitions - skipping" ;-) (whatever you prefer) > +elif [ "$(parser_supports 'pivot_root -> foo,')" != "true" ] ; then > + #pivot_root domain transitions not supported > + echo " parser does not support pivot root domain transitions > skipping tests ..." Same here. Pre-Acked-by: Christian Boltz <[email protected]> - feel free to commit to bzr without sending a patch first. Regards, Christian Boltz -- alles drumherum ist Schrott... Natürlich nur, wenn Du nicht wieder eine deiner revolutionären Ideen hast. :-) Vielleicht eine chroot-Umgebung pro compare-Prozess mit /tmp in einer initrd? :-)))) [Ratti in fontlinge-devel]
signature.asc
Description: This is a digitally signed message part.
-- AppArmor mailing list [email protected] Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/apparmor
