On Wed 05-07-23 15:01:54, Jeff Layton wrote:
> In later patches, we're going to change how the inode's ctime field is
> used. Switch to using accessor functions instead of raw accesses of
> inode->i_ctime.
> 
> Signed-off-by: Jeff Layton <[email protected]>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <[email protected]>

                                                                Honza

> ---
>  security/apparmor/apparmorfs.c    | 6 +++---
>  security/apparmor/policy_unpack.c | 4 ++--
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/security/apparmor/apparmorfs.c b/security/apparmor/apparmorfs.c
> index 3d0d370d6ffd..7dbd0a5aaeeb 100644
> --- a/security/apparmor/apparmorfs.c
> +++ b/security/apparmor/apparmorfs.c
> @@ -226,7 +226,7 @@ static int __aafs_setup_d_inode(struct inode *dir, struct 
> dentry *dentry,
>  
>       inode->i_ino = get_next_ino();
>       inode->i_mode = mode;
> -     inode->i_atime = inode->i_mtime = inode->i_ctime = current_time(inode);
> +     inode->i_atime = inode->i_mtime = inode_set_ctime_current(inode);
>       inode->i_private = data;
>       if (S_ISDIR(mode)) {
>               inode->i_op = iops ? iops : &simple_dir_inode_operations;
> @@ -1557,7 +1557,7 @@ void __aafs_profile_migrate_dents(struct aa_profile 
> *old,
>               if (new->dents[i]) {
>                       struct inode *inode = d_inode(new->dents[i]);
>  
> -                     inode->i_mtime = inode->i_ctime = current_time(inode);
> +                     inode->i_mtime = inode_set_ctime_current(inode);
>               }
>               old->dents[i] = NULL;
>       }
> @@ -2546,7 +2546,7 @@ static int aa_mk_null_file(struct dentry *parent)
>  
>       inode->i_ino = get_next_ino();
>       inode->i_mode = S_IFCHR | S_IRUGO | S_IWUGO;
> -     inode->i_atime = inode->i_mtime = inode->i_ctime = current_time(inode);
> +     inode->i_atime = inode->i_mtime = inode_set_ctime_current(inode);
>       init_special_inode(inode, S_IFCHR | S_IRUGO | S_IWUGO,
>                          MKDEV(MEM_MAJOR, 3));
>       d_instantiate(dentry, inode);
> diff --git a/security/apparmor/policy_unpack.c 
> b/security/apparmor/policy_unpack.c
> index ed180722a833..8b8846073e14 100644
> --- a/security/apparmor/policy_unpack.c
> +++ b/security/apparmor/policy_unpack.c
> @@ -89,10 +89,10 @@ void __aa_loaddata_update(struct aa_loaddata *data, long 
> revision)
>               struct inode *inode;
>  
>               inode = d_inode(data->dents[AAFS_LOADDATA_DIR]);
> -             inode->i_mtime = inode->i_ctime = current_time(inode);
> +             inode->i_mtime = inode_set_ctime_current(inode);
>  
>               inode = d_inode(data->dents[AAFS_LOADDATA_REVISION]);
> -             inode->i_mtime = inode->i_ctime = current_time(inode);
> +             inode->i_mtime = inode_set_ctime_current(inode);
>       }
>  }
>  
> -- 
> 2.41.0
> 
-- 
Jan Kara <[email protected]>
SUSE Labs, CR

Reply via email to