Re: [apparmor] [PATCH 1/1] apparmor: avoid per-cpu hold underflow in aa_get_buffer

[John Johansen]

On 1/19/26 04:21, Zhengmian Hu wrote:

Signed-off-by: Zhengmian Hu <huzhengm...@gmail.com>

Small nit, there is no patch description. I can pull that from patch [0/1] if 
you are okay with that, otherwise can you send in a v2?

I will pull this in once I know your preference

---
  security/apparmor/lsm.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/security/apparmor/lsm.c b/security/apparmor/lsm.c
index 9b6c2f157..a6c884ba6 100644
--- a/security/apparmor/lsm.c
+++ b/security/apparmor/lsm.c
@@ -1868,7 +1868,8 @@ char *aa_get_buffer(bool in_atomic)
        if (!list_empty(&cache->head)) {
                aa_buf = list_first_entry(&cache->head, union aa_buffer, list);
                list_del(&aa_buf->list);
-               cache->hold--;
+               if (cache->hold)
+                       cache->hold--;
                cache->count--;
                put_cpu_ptr(&aa_local_buffers);
                return &aa_buf->buffer[0];