On Wed, 2026-02-04 at 15:57 +1100, NeilBrown wrote: > From: NeilBrown <[email protected]> > > This kerneldoc comment was always meant for start_dirop(), not for > __start_dirop() which is a static function and doesn't need > documentation. > > It was in the wrong place and was then incorrectly renamed (instead of > moved) and useless "documentation" was added for "@state" was provided. > > This patch reverts the name, removes the mention of @state, and moves > the comment to where it belongs. > > Signed-off-by: NeilBrown <[email protected]> > --- > fs/namei.c | 27 +++++++++++++-------------- > 1 file changed, 13 insertions(+), 14 deletions(-) > > diff --git a/fs/namei.c b/fs/namei.c > index b28ecb699f32..40af78ddfb1b 100644 > --- a/fs/namei.c > +++ b/fs/namei.c > @@ -2841,20 +2841,6 @@ static int filename_parentat(int dfd, struct filename > *name, > return __filename_parentat(dfd, name, flags, parent, last, type, NULL); > } > > -/** > - * __start_dirop - begin a create or remove dirop, performing locking and > lookup > - * @parent: the dentry of the parent in which the operation will occur > - * @name: a qstr holding the name within that parent > - * @lookup_flags: intent and other lookup flags. > - * @state: task state bitmask > - * > - * The lookup is performed and necessary locks are taken so that, on success, > - * the returned dentry can be operated on safely. > - * The qstr must already have the hash value calculated. > - * > - * Returns: a locked dentry, or an error. > - * > - */ > static struct dentry *__start_dirop(struct dentry *parent, struct qstr *name, > unsigned int lookup_flags, > unsigned int state) > @@ -2876,6 +2862,19 @@ static struct dentry *__start_dirop(struct dentry > *parent, struct qstr *name, > return dentry; > } > > +/** > + * start_dirop - begin a create or remove dirop, performing locking and > lookup > + * @parent: the dentry of the parent in which the operation will occur > + * @name: a qstr holding the name within that parent > + * @lookup_flags: intent and other lookup flags. > + * > + * The lookup is performed and necessary locks are taken so that, on success, > + * the returned dentry can be operated on safely. > + * The qstr must already have the hash value calculated. > + * > + * Returns: a locked dentry, or an error. > + * > + */ > struct dentry *start_dirop(struct dentry *parent, struct qstr *name, > unsigned int lookup_flags) > {
Reviewed-by: Jeff Layton <[email protected]>
