> SEND_SIG_NOINFO is defined as ((struct kernel_siginfo *) 0), so passing > NULL works, but: > > - this works "by accident" and looks as if the caller doesn't understand > the signal sending API. > > - more importantly, this hides the usage of SEND_SIG_NOINFO from grep, > and this is really bad. - also drop the now redundant (void) > Reviewed-by: Bradley Morgan <[email protected]> > Signed-off-by: Oleg Nesterov <[email protected]> > --- > security/apparmor/audit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/security/apparmor/audit.c b/security/apparmor/audit.c > index 4a60b6fda75f..15e42e96b163 100644 > --- a/security/apparmor/audit.c > +++ b/security/apparmor/audit.c > @@ -192,7 +192,7 @@ int aa_audit(int type, struct aa_profile *profile, > aa_audit_msg(type, ad, cb); > > if (ad->type == AUDIT_APPARMOR_KILL) > - (void)send_sig_info(profile->signal, NULL, > + send_sig_info(profile->signal, SEND_SIG_NOINFO, > ad->common.type == LSM_AUDIT_DATA_TASK && > ad->common.u.tsk ? ad->common.u.tsk : current); > > -- > 2.52.0
Also, feel free to CC me in signal patches, so I can review, from you or from others. Thanks!
