Author: randyk
Date: Wed Apr 25 22:28:02 2007
New Revision: 532620
URL: http://svn.apache.org/viewvc?view=rev&rev=532620
Log:
For Win32, remove the
flag |= APR_FILE_NOCLEANUP | APR_SHARELOCK;
in apreq_file_cleanup, to avoid problems with file uploads [suggested by Vinay
Y S, tested by Steve Hay and Peter Walsham]
Modified:
httpd/apreq/trunk/CHANGES
httpd/apreq/trunk/library/util.c
Modified: httpd/apreq/trunk/CHANGES
URL:
http://svn.apache.org/viewvc/httpd/apreq/trunk/CHANGES?view=diff&rev=532620&r1=532619&r2=532620
==============================================================================
--- httpd/apreq/trunk/CHANGES (original)
+++ httpd/apreq/trunk/CHANGES Wed Apr 25 22:28:02 2007
@@ -4,6 +4,11 @@
@section v2_10 Changes with libapreq2-2.10 (under developement)
+- C API [suggested by Vinay Y S, tested by Steve Hay and Peter Walsham]
+ For Win32, remove the
+ flag |= APR_FILE_NOCLEANUP | APR_SHARELOCK;
+ in apreq_file_cleanup, to avoid problems with file uploads.
+
@section v2_09 Changes with libapreq2-2.09 ()
- C API [joes]
Modified: httpd/apreq/trunk/library/util.c
URL:
http://svn.apache.org/viewvc/httpd/apreq/trunk/library/util.c?view=diff&rev=532620&r1=532619&r2=532620
==============================================================================
--- httpd/apreq/trunk/library/util.c (original)
+++ httpd/apreq/trunk/library/util.c Wed Apr 25 22:28:02 2007
@@ -823,14 +823,7 @@
/* NO APR_DELONCLOSE! see comment above */
flag = APR_CREATE | APR_READ | APR_WRITE | APR_EXCL | APR_BINARY;
- /* Win32 needs the following to remove temp files.
- * XXX: figure out why the APR_SHARELOCK flag works;
- * a grep through the httpd sources seems to indicate
- * it's only used in sdbm files??
- */
-#ifdef WIN32
- flag |= APR_FILE_NOCLEANUP | APR_SHARELOCK;
-#endif
+
rc = apr_file_mktemp(fp, tmpl, flag, pool);
if (rc == APR_SUCCESS) {
