Ville Skytt� <[EMAIL PROTECTED]> writes:
> $r->discard_request_body() fixes it here too.
Ok, here's what I'd like you (or Markus) to do.
1) grab our svn trunk and apply the attached patch to it.
2) make clean; make
3) cd module; make test
4) ls -l /tmp
When the tests finish, they should leave three temporary files
in /tmp:
% ls -l /tmp
total 1493
-rw------- 1 joe joe 500024 May 19 22:32 apreqStetos
-rw------- 1 joe joe 500039 May 19 22:32 apreqT5oOq1
-rw------- 1 joe joe 500039 May 19 22:32 apreqs16lOA
We need to figure out which side the leak is happening on (writing
to the spool file or reading from it). The presence/absense of these
files on your box should help us make that determination, so let us
know what you see.
Index: module/t/c-modules/apreq_request_test/mod_apreq_request_test.c
===================================================================
--- module/t/c-modules/apreq_request_test/mod_apreq_request_test.c
(revision 171027)
+++ module/t/c-modules/apreq_request_test/mod_apreq_request_test.c
(working copy)
@@ -54,10 +54,10 @@
ap_log_rerror(APLOG_MARK, APLOG_DEBUG, APR_SUCCESS,
r, "starting apreq_request_test");
- s = ap_discard_request_body(r);
+// s = ap_discard_request_body(r);
- ap_log_rerror(APLOG_MARK, APLOG_DEBUG, s,
- r, "discard request body");
+// ap_log_rerror(APLOG_MARK, APLOG_DEBUG, s,
+// r, "discard request body");
ap_set_content_type(r, "text/plain");
ap_rputs("ARGS:\n",r);
Index: library/util.c
===================================================================
--- library/util.c (revision 171027)
+++ library/util.c (working copy)
@@ -971,8 +971,8 @@
data = apr_palloc(pool, sizeof *data);
/* cleanups are LIFO, so this one will run just after
the cleanup set by mktemp */
- apr_pool_cleanup_register(pool, data,
- apreq_file_cleanup, apreq_file_cleanup);
+// apr_pool_cleanup_register(pool, data,
+// apreq_file_cleanup, apreq_file_cleanup);
rc = apr_file_mktemp(fp, tmpl, /* NO APR_DELONCLOSE! see comment above */
APR_CREATE | APR_READ | APR_WRITE
--
Joe Schaefer
