Fowarding to apreq-dev list where we will review this.
-- ------------------------------------------------------------------------ Philip M. Gollucci ([EMAIL PROTECTED]) 323.219.4708 Consultant / http://p6m7g8.net/Resume/resume.shtml Senior Software Engineer - TicketMaster - http://ticketmaster.com 1024D/A79997FA F357 0FDD 2301 6296 690F 6A47 D55A 7172 A799 97F "It takes a minute to have a crush on someone, an hour to like someone, and a day to love someone, but it takes a lifetime to forget someone..."
--- Begin Message ---On 3/30/06, Cory Omand <[EMAIL PROTECTED]> wrote: > On 3/29/06, Philip M. Gollucci <[EMAIL PROTECTED]> wrote: > > > Can't load > > > '/export/medusa/comand/csw/cpan/libapreq2/work/comand-ra.d/libapreq2-2.07/glue/perl/t/cgi-bin/../../blib/arch/auto/APR/Request/Request.so' > > > for module APR::Request: ld.so.1: test_cgi.pl: fatal: libapreq2.so.3: > > set the LD_LIBRARY_PATH in your shell to the appropriate paths. Thats > > strange. This isn't your problem, but I'm hoping the test out will give me > > something to go on. I'm having some "issues" looking at ndm instead of gdb. > > It turned out that thanks to libtool, the module and library tests > were pointing to the uninstalled version of libapreq, allowing the > tests to run normally. However, the uninstalled glue Request.so > module was *not* pointing anywhere useful, and could not find either > libapreq2 or libapr/aprutil. No matter what I did, I could not make > the glue test suite utilize my LD_LIBRARY_PATH. Not sure why. > Copying the libs from library/.libs to the destination path before > running the tests finally allowed the tests to load the library. > > Fixing the library loading issues unmasked a different set of test > failures. It appears that the test suite relies on 'perltoc.pod' and > 'perlport.pod' being installed. My perl installation splits the pod > docs out from the core perl, and other distributions may do the same. > Perhaps relying on a pod that is required in the perl core (like > perldiag.pod, or Config.pm) might be a better idea? > > After I installed the pod docs, all tests pass, but usage from within > Apache still yields a segfault when creating new Request objects. Now > I am extremely confused. I verified that the identical library > versions are present on the target system, and that all shared objects > are able to locate libapr/aprutil/apreq2. Any ideas? Here is an interesting fact that I did not realize until just a moment ago. If you declare a mod_perl 2.x handler as: package Some::Module; sub handler { my $r = shift; } Your $r will be an instance of Apache2::RequestRec. However, if you declare your handler as: package Some::Module; sub handler :method { my $r = shift; } Your $r will be an instance of Some::Module! This is the way my test handler was defined, which I gleaned recently from the mod_perl 2.0 docs. I guess I didn't read far enough into the docs to realize what ':method' was doing to my argument list. Anyway, if you pass an instance of Some::Module to the constructor of Apache2::Request or Apache2::Cookie, apache will segfault. I would have expected Apache2::Request to complain to me about the object class if I passed it an unexpected class, not a segv. I've attached a patch which would bail if anything but an instance of Apache2::RequestRec is passed to Apache2::Request or Apache2::Cookie constructors... - C.diff --speed-large-files --minimal -Nru libapreq2-2.07.orig/glue/perl/lib/Apache2/Cookie.pm libapreq2-2.07/glue/perl/lib/Apache2/Cookie.pm --- libapreq2-2.07.orig/glue/perl/lib/Apache2/Cookie.pm 2006-03-30 15:38:22.190911000 -0500 +++ libapreq2-2.07/glue/perl/lib/Apache2/Cookie.pm 2006-03-30 15:36:32.507324000 -0500 @@ -13,6 +13,10 @@ sub new { my ($class, $r, %attrs) = @_; + die "argument is not an Apache2::RequestRec object" + unless ref($r) + and UNIVERSAL::isa($r, 'Apache2::RequestRec'); + my ($name) = grep {defined} delete $attrs{name} , delete $attrs{-name}; my ($value) = grep {defined} delete $attrs{value}, delete $attrs{-value}; return unless defined $name and defined $value; diff --speed-large-files --minimal -Nru libapreq2-2.07.orig/glue/perl/lib/Apache2/Request.pm libapreq2-2.07/glue/perl/lib/Apache2/Request.pm --- libapreq2-2.07.orig/glue/perl/lib/Apache2/Request.pm 2006-03-30 15:38:22.225054000 -0500 +++ libapreq2-2.07/glue/perl/lib/Apache2/Request.pm 2006-03-30 15:37:03.251079000 -0500 @@ -12,7 +12,12 @@ sub new { my $class = shift; - my $req = $class->APR::Request::Apache2::handle(shift); + my $r = shift; + die "argument is not an Apache2::RequestRec object" + unless ref($r) + and UNIVERSAL::isa($r, 'Apache2::RequestRec'); + + my $req = $class->APR::Request::Apache2::handle($r); my %attrs = @_; while (my ($k, $v) = each %attrs) {
--- End Message ---
