The patch looks good to me too. I'd been planning to implement this feature some weekend and the patch is pretty much how I'd do it, so I'd +1 it once the corresponding tests are written.
----- Original Message ---- > From: Issac Goldstand <mar...@beamartyr.net> > To: apreq-dev@httpd.apache.org > Sent: Mon, November 8, 2010 8:17:31 AM > Subject: Re: HttpOnly > > On 08/11/2010 12:48, Clinton Gormley wrote: > > Hi all > > > > Any plans on adding support to Apache2::Cookie for the HttpOnly flag? > > > > I see a patch in Debian which does this: > > > > http://www.mail-archive.com/debian-bugs-d...@lists.debian.org/msg543361.html > > > > thanks > > > > Clint > > > > > > The patch looks ok to me at first glance. If you're willing to write > the unit test(s) for this, I'd be happy to help push this . >
