Control: tags -1 + pending

Hi Andreas,

2014-08-12 16:21 Andreas Tolfsen:
Package: aptitude
Version: 0.6.11-1
Severity: minor

Dumb terminals only support a limited number of control codes.  In
particular they do not have the ability to process ANSI escape
sequences which are commonly used for a number of aptitude's commands
to display progress of steps.

As far as I can gather this is a matter of avoiding some of the
conditionals in the switch statement in src/download_item.cc:77.
The problematic cases are the “transient” states: StatIdle,
StatFetching, and StatDone.

This makes the output of the following command rather ugly:

~ % TERM=dumb aptitude update

0% [Working]

Ign http://ppa.launchpad.net trusty InRelease

17% [Connecting to ftp.no.debian.org (2001:700:0:12e::f70)]
[...]
94% [Working]
[  0%] Reading package lists

[100%] Reading package lists


The expected output should be what you see in an intelligent terminal:

~ % aptitude update
Ign http://ppa.launchpad.net trusty InRelease
Hit http://ppa.launchpad.net trusty Release.gpg
Hit http://ppa.launchpad.net trusty Release
Hit http://ppa.launchpad.net trusty/main Sources
Hit http://ppa.launchpad.net trusty/main amd64 Packages
Ign http://ppa.launchpad.net trusty/main Translation-en_US
Ign http://ppa.launchpad.net trusty/main Translation-en
Ign http://ppa.launchpad.net trusty/main Translation-en_GB
Hit http://ftp.no.debian.org sid InRelease
Hit http://ftp.no.debian.org sid/main Sources/DiffIndex
Hit http://ftp.no.debian.org sid/main amd64 Packages/DiffIndex
Hit http://ftp.no.debian.org sid/main Translation-en/DiffIndex

Thanks for the report.

The problem was elsewhere (cmdline_progress.cc and
cmdline_download_progress_display.cc, not src/download_item.cc).

Now I added a check to check for TERM=dumb, as well as in previous cases
when the output was a file or quite>0 -- in those cases the output would
be like in your second example.

Marking as +pending, it will be present in the next release.


Cheers.
--
Manuel A. Fernandez Montecelo <[email protected]>

_______________________________________________
Aptitude-devel mailing list
[email protected]
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/aptitude-devel

Reply via email to