Am Dienstag, 13. Februar 2007 18:17 schrieb Martin Preuss:
> > > This happens in hbci.c in AH_HBCI_AddUserPath() and
> > > AH_HBCI_AddObjectPath because GWEN_Path_Convert(...,
> > > GWEN_PATH_FLAGS_ESCAPE) is called there that should escape the whole
> > > path. It is clearly wrong that this escapes the initial "C:\" as well.
> > > Should we remove that GWEN_Path_Convert altogether? Martin, any idea?
>
> [...]
> Hmm, just looked at it: It is not at AH_HBCI_AddUserPath() where the
> conversion takes place: That call only converts the userId (first argument)
> and stores the converted result in the given buffer which basically adds an
> escaped version of the user id to the buffer.
>
> Could you add a printf or something alike to show the content of the path
> upon return from AH_HBCI_AddUserPath()?

Sorry, no, I'm not at the windows computer anymore.

But doesn't the path escaping just happen in AH_HBCI_LoadSettings and 
SaveSettings in hbci.c? GWEN_Path_Convert is used there.

Hm. The calling sequence from AH_HBCI_SaveMessage -> AddCustomerPath -> 
AddUserPath will find the initial part of the path from 
AB_Provider_GetUserDataDir, but since "certs" and another directory were 
correctly found without extra escaping, this one probably returns the path 
unescaped.

By the way, is the "64" in AH_HBCI_SaveMessage's GWEN_Buffer_new() a hardlimit 
for the path names? This should be raised to something beyond 200 because on 
windows the paths can easily get longer than that.

I'm also not so sure what to do. GWEN_Path_Convert in itself cannot just 
ignore "?:" because it cannot know whether we are at the start of the 
directroy path (no escaping) or somewhere in the middle (escaping necessary). 
Yet another Flag? But that's not at all elegant...

By the way, in hbci.c there are still '/' in two places; I suppose those 
should be replaced by AppendString and AH_PATH_SEP...

Christian

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Aqbanking-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/aqbanking-devel

Reply via email to